Skip to content

Commit

Permalink
Update care expense pages (#32850)
Browse files Browse the repository at this point in the history
* Update care expense pages

* Update pull request template
  • Loading branch information
ToddWebDev authored Nov 4, 2024
1 parent f986121 commit bac2287
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 24 deletions.
20 changes: 1 addition & 19 deletions src/applications/pensions/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
**Note**: Delete the description statements, complete each step. **None are optional**, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

## Are you removing, renaming or moving a folder in this PR?

- [ ] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
- [ ] Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a `manifest.json`, search for its `entryName` in the content-build [registry.json](https://github.com/department-of-veterans-affairs/content-build/blob/main/src/applications/registry.json) (the `entryName` there will match).

If an entry for this folder exists in content-build and you are:

1. **Deleting a folder**:

**Deleting a folder**:
1. First search `vets-website` for _all_ instances of the `entryName` in your `manifest.json` and remove them in a separate PR. Look particularly for references in `src/applications/static-pages/static-pages-entry.js` and `src/platform/forms/constants.js`. _**If you do not do this, other applications will break!**_

- _Add the link to your merged vets-website PR here_
Expand All @@ -22,65 +20,52 @@ If an entry for this folder exists in content-build and you are:
2. **Renaming or moving a folder**: Update the entry in the [registry.json](https://github.com/department-of-veterans-affairs/content-build/blob/main/src/applications/registry.json), but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

### :warning: TeamSites :warning:

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the `#sitewide-public-websites` Slack channel for questions.

## Did you change site-wide styles, platform utilities or other infrastructure?

- [ ] No
- [ ] Yes, and I used the [proxy-rewrite steps](https://github.com/department-of-veterans-affairs/vets-website/tree/main/src/applications/proxy-rewrite#that-sounds-normal-so-whats-the-proxy-all-about) to test the injected header scenario

## Summary

Summary of changes on the Pension Benefits form (21P-527EZ)

## Issue

- _Link to ticket created in va.gov-team repo_

## Related issue(s)

- _Link to previous change of the code/bug (if applicable)_
- _Link to epic if not included in ticket_

## Associated Pull Request(s)

- _Link to associated vets-website, vets-api or vets-json-schema PR (if applicable)_
- _Link to previous changes (if applicable)_

## How to run in local environment

1. Check out this branch locally
2. Run `vets-website` and `vets-api`
3. In your local environment, set the `{{flipper_name}}` flipper to 'enabled' at http://localhost:3000/flipper/features/{{flipper_name}} (if applicable)
4. Go to `http://localhost:3001/pension/apply-for-veteran-pension-form-21p-527ez/` in your browser

## How to verify

1. _Step 1_
2. _Step 2_
3. _Step 3_

## What areas of the site does it impact?

Pension Benefits Application

## Screenshots

### Desktop

| Before | After |
| ----------- | ----------- |
| Upload file | Upload file |

### Mobile (if applicable)

| Before | After |
| ----------- | ----------- |
| Upload file | Upload file |

### Quality Assurance & Testing

- [ ] New unit tests (if applicable)
- [ ] New E2E tests added (if applicable)
- [ ] Existing unit tests and integration tests are passing
Expand All @@ -92,15 +77,12 @@ Pension Benefits Application
- [ ] [Accessibility testing](https://depo-platform-documentation.scrollhelp.site/developer-docs/wcag-2-1-success-criteria-and-foundational-testing) has been performed

### Error Handling

- [ ] Browser console contains no warnings or errors.
- [ ] Events are being sent to the appropriate logging solution
- [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

### Authentication

- [ ] Did you login to a local build and verify all authenticated routes work as expected with a test user

## Requested Feedback

(OPTIONAL) _What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?_
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ const { ONE_TIME, ...careFrequencyLabelsWithoutOneTime } = careFrequencyLabels;
/** @type {ArrayBuilderOptions} */
const options = {
arrayPath: 'careExpenses',
nounSingular: 'Care expense',
nounPlural: 'Care expenses',
nounSingular: 'care expense',
nounPlural: 'care expenses',
required: false,
isItemIncomplete: item =>
!item?.recipients ||
Expand All @@ -42,13 +42,15 @@ const options = {
!item.paymentAmount, // include all required fields here
text: {
summaryTitleWithoutItems: 'Care expenses',
getItemName: item => recipientTypeLabels[item.recipients],
getItemName: item => item.provider,
cardDescription: item =>
item?.paymentAmount && (
<ul className="u-list-no-bullets vads-u-padding-left--0 vads-u-font-weight--normal">
<li>
Care provider:{' '}
<span className="vads-u-font-weight--bold">{item.provider}</span>
Care recipient:{' '}
<span className="vads-u-font-weight--bold">
{recipientTypeLabels[item.recipients]}
</span>
</li>
<li>
Care type:{' '}
Expand Down

0 comments on commit bac2287

Please sign in to comment.