Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove podiatry from type of care list #32980

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Nov 12, 2024

Summary

This removes/hides Podiatry from the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature flag is true.

Related issue(s)

department-of-veterans-affairs/va.gov-team#95332

Testing done

  • Local testing
  • e2e testing
  • Unit testing

Screenshots

With vaOnlineSchedulingRemovePodiatry set to false

localhost_3001_my-health_appointments_($small-screen)

With vaOnlineSchedulingRemovePodiatry set to true

localhost_3001_my-health_appointments_schedule_type-of-care($small-screen)

Acceptance criteria

Podiatry should not be shown as an option on the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature is set to true.

Podiatry should be shown as an option on the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature is set to false and the CC flag is on.

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Screenshot of the developed feature is added

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Signed-off-by: Ryan Shaw <[email protected]>
Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw ryanshaw self-assigned this Nov 12, 2024
@@ -373,6 +374,7 @@ export function selectTypeOfCarePage(state) {
pageChangeInProgress: selectPageChangeInProgress(state),
showCommunityCare: selectFeatureCommunityCare(state),
showDirectScheduling: selectFeatureDirectScheduling(state),
removePodiatry: selectFeatureRemovePodiatry(state),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the removePodiatry variable name here as all of the other variables are showSomething but wanted to keep it consistent with what the feature flag was originally named.

typeOfCare => typeOfCare.id !== PODIATRY_ID || showCommunityCare,
typeOfCare =>
typeOfCare.id !== PODIATRY_ID ||
(showCommunityCare && !removePodiatry),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the removePodiatry variable name here as all of the other variables are showSomething but wanted to keep it consistent with what the feature flag was originally named.

…-website into ryanshaw/95332-remove-podiatry-from-type-of-care-list
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/95332-remove-podiatry-from-type-of-care-list/main November 12, 2024 15:10 Inactive
Signed-off-by: Ryan Shaw <[email protected]>
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanshaw ryanshaw merged commit 5e1dd7b into main Nov 13, 2024
76 of 79 checks passed
@ryanshaw ryanshaw deleted the ryanshaw/95332-remove-podiatry-from-type-of-care-list branch November 13, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants