[CST] - Update AddFiles form tests #33044
Draft
+113
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initially our team found that
AddFilesForm
had a bug after a user had added a file, when the user tried the select theChange File
button and changed the file the componentva-file-input
reflected the new file butAddFilesForm
was still showing both files. After investigation we found a larger bug which was that on Aug 13th the platform design team removed the ability to use the V1 version of theva-file-input
component which is what your code onAddFilesForm
was relying on, thus breaking upload section of the CST and only allowing users to upload one file at a time instead of multiple uploads.Discussed this issue with the platform design team here. They are going to fix the issue by moving our component library back to the version that had the V1 component.
In this pr I am adding more tests so that in the future if this were to happen again we would catch it!
Related issue(s)
[CST] Bug in file upload when replacing one file with another va.gov-team#96817
department-of-veterans-affairs/vets-website#0000
- Link to epic if not included in ticket
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?