Skip to content

Commit

Permalink
Merge pull request #11302 from dependabot/markhallen/remove-npm6-remn…
Browse files Browse the repository at this point in the history
…ants

Remove `cafile` hack used for NPM 6
  • Loading branch information
markhallen authored Jan 14, 2025
2 parents 83b0751 + cf69f25 commit b39f1f8
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions updater/config/.npmrc
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
# TODO: Remove these hacks once we've deprecated npm 6 support as it no longer
# spwans a child process to npm install git dependencies.

# Only set our custom CA cert for npm because the system ca's + our custom ca
# causes npm to blow up when installing git dependencies (E2BIG exception). This
# happens because the ca-file contents are passed as a cli argument to npm
# install from npm/cli/lib/pack.js as --ca="contents of ca file" - "ca" is
# populated automatically by npm when setting "--cafile" and passed through in
# when spawning the cli to install git dependencies.
cafile=/usr/local/share/ca-certificates/dbot-ca.crt
# Because npm doesn't pass through all npm config when doing git installs in
# npm/cli/lib/pack.js we also need to disable audit here to prevent npm from
# auditing git dependencies, we do this to sped up installs
Expand Down

0 comments on commit b39f1f8

Please sign in to comment.