Remove the check for the NPM 6 cafile
in .npmrc
#11307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This is a follow-up to #11302
It seems that this spec should have failed, but it didn't because CI used a cached docker container.
Anything you want to highlight for special attention from reviewers?
The spec is now redundant as we have removed the assignment for the NPM 6
cafile
in.npmrc
.How will you know you've accomplished your goal?
We can recreate the issue:
main
branch runbin/docker-dev-shell npm_and_yarn --rebuild
cd npm_and_yarn && rspec ./spec/npm_and_yarn_config_spec.rb
cafile
hack used for NPM 6 #11302,git revert cf69f2537e5fab87a40acdeaad362d7a84042da6
bin/docker-dev-shell npm_and_yarn --rebuild
cd npm_and_yarn && rspec ./spec/npm_and_yarn_config_spec.rb
Checklist