Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sorbet types as strict for Python Module #11432

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fixed sorbet types as strict for Python Module #11432

merged 2 commits into from
Jan 29, 2025

Conversation

randhircs
Copy link
Member

What are you trying to accomplish?

Fixed sorbet types as strict for Python Module

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@randhircs randhircs requested a review from a team as a code owner January 29, 2025 01:45
sachin-sandhu
sachin-sandhu approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randhircs randhircs force-pushed the sorbet_type_python_module branch from b232b86 to 3c25061 Compare January 29, 2025 18:48
@randhircs randhircs merged commit 992818e into main Jan 29, 2025
60 checks passed
@randhircs randhircs deleted the sorbet_type_python_module branch January 29, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-sandhu sachin-sandhu sachin-sandhu approved these changes

@thavaahariharangit thavaahariharangit thavaahariharangit approved these changes

Assignees
No one assigned
Labels
L: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randhircs @thavaahariharangit @sachin-sandhu