Raise DependencyFileUnsupported error when API returns matching 400 error

[amazimbe]

What are you trying to accomplish?

Handle the error below:

Dependabot::ApiError
{"errors":[{"status":400,"title":"Bad Request","detail":"The request contains invalid or unauthorized changes"}]}
dependabot-updater/lib/dependabot/api_client.rb in block in create_pull_request at line 44

so that it no longer appears in Sentry.

Anything you want to highlight for special attention from reviewers?

The above response is returned from dependabot-api UpdateJobs::CreatePullRequest.handle_invalid_dependency_files when the dependency files are invalid. There's not much we can do to prevent this API error but we need to handle it correctly so that it doesn't appear in Sentry as an Unknown Error.

How will you know you've accomplished your goal?

The above error won't appear in Sentry anymore.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[markhallen]

nit, we could satisfy the cop if we extracted some logic out into it's own method

[amazimbe]

It's the class length so we would have to extract a mixin but then extracting a mixin just for this would probably not be worth it.

[markhallen]

I think we should really make an effort to adhere by the suggestions from rubocop rather than disable them. Especially for a core class that is shared across ecosystems.

[sachin-sandhu]

Approving based on discussion

[abdulapopoola]

do you know why we do this?

[amazimbe]

To quote the API code, it's because we are trying to update GitHub Actions workflow files when our package manager is not github_actions or the dependency file is not one of the files specified in the allowed list .

It was added as a fix to prevent any potential security issues raised in issue

[abdulapopoola]

Thanks. Adding @honeyankit as a reviewer.