Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 내 정보 뽀각 페이지 UI 구현 #15
feat: 내 정보 뽀각 페이지 UI 구현 #15
Changes from 9 commits
c43f09d
9c76079
d581a29
c8979c3
9147c3c
cacfb55
c7ec629
b292977
d99b86c
3c2e350
21f8294
6732439
616c404
6e26999
2ec446a
73d4230
ac69449
2eb7714
632d906
8c5fd69
d35099d
c05b498
bafab50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 div 태그가 없어도 괜찮을 것이라고 생각하는데 어떻게 생각하시나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 div 태그가 없다면 상단 div의 flex 속성 때문에 위 사진처럼 more 버튼의 height가 늘어나게 됩니다(원래는 정사각형).
버튼의 모양은 유지하면서 버튼의 배치만 지정하기 위해 div 태그로 한 번 감싸주게 되었습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CardList라면 section 태그가 어떤지 여쭤보고 싶습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넹 좋은 것 같습니다! 반영했어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
목데이터라 큰 의미 업겟지만... 혹시.. 여기만 string으로 안묶은 이유가 따로 잇는건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경험 정리
와면접 질문
은 중간에 띄어쓰기가 들어가기 때문에 객체의 key값으로 인식 못해서 따옴표로 묶어줬어용반면에 자기소개서는 띄어쓰기가 없기 때문에 따옴표 없이도 key 값으로 인식합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 clsx 대신 쓰는 것 맞죠?? 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넹 clsx와 twMerge의 기능을 같이 해주는 유틸함수입니다!
This file was deleted.