Update rule-descriptions.md #4633
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good to put in a link to ACT
WilcoFiers
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Good suggestion. This is a generated file though. We'll have to make the change here in order for it not to get clobbered next time someone updates a rule:
https://github.com/dequelabs/axe-core/blob/develop/build/configure.js#L19
|
@mgifford any update on this pr? |
|
@straker I think this is waiting for the next build. Something @WilcoFiers would have more influence over. I'm just a very satisfied user. |
|
@mgifford this isn't waiting for a build. To get this in you'll have to make the change here instead of where you put it now: |
Removing change here.
Updating patch as directed in conversation.
|
Ok, @WilcoFiers I moved the patch. Hopefully that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good to put in a link to ACT
Just adding a link as it wasn't clear to someone new to this.