Merge pull request #308 from hacheraw/controller-events

Remove return type for Controller events
dereuromark · Jun 19, 2023 · 3c9c9b5 · 3c9c9b5
2 parents f5289db + a9ea461
commit 3c9c9b5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/src/CodeCompletion/Task/ControllerEventsTask.php b/src/CodeCompletion/Task/ControllerEventsTask.php
@@ -21,19 +21,19 @@ public function type(): string {
 	 */
 	public function create(): string {
 		$events = <<<'TXT'
-		public function startup(EventInterface $event): ?Response {
+		public function startup(EventInterface $event) {
 			return null;
 		}
-		public function beforeFilter(EventInterface $event): ?Response {
+		public function beforeFilter(EventInterface $event) {
 			return null;
 		}
-		public function beforeRender(EventInterface $event): ?Response {
+		public function beforeRender(EventInterface $event) {
 			return null;
 		}
-		public function afterFilter(EventInterface $event): ?Response {
+		public function afterFilter(EventInterface $event) {
 			return null;
 		}
-		public function shutdown(EventInterface $event): ?Response {
+		public function shutdown(EventInterface $event) {
 			return null;
 		}
 		public function beforeRedirect(EventInterface $event, $url, Response $response) {

diff --git a/tests/TestCase/CodeCompletion/Task/ControllerEventsTaskTest.php b/tests/TestCase/CodeCompletion/Task/ControllerEventsTaskTest.php
@@ -34,19 +34,19 @@ public function testCollect() {
 
 if (false) {
 	abstract class Controller {
-		public function startup(EventInterface $event): ?Response {
+		public function startup(EventInterface $event) {
 			return null;
 		}
-		public function beforeFilter(EventInterface $event): ?Response {
+		public function beforeFilter(EventInterface $event) {
 			return null;
 		}
-		public function beforeRender(EventInterface $event): ?Response {
+		public function beforeRender(EventInterface $event) {
 			return null;
 		}
-		public function afterFilter(EventInterface $event): ?Response {
+		public function afterFilter(EventInterface $event) {
 			return null;
 		}
-		public function shutdown(EventInterface $event): ?Response {
+		public function shutdown(EventInterface $event) {
 			return null;
 		}
 		public function beforeRedirect(EventInterface $event, $url, Response $response) {
@@ -55,19 +55,19 @@ public function beforeRedirect(EventInterface $event, $url, Response $response)
 	}
 
 	abstract class Component {
-		public function startup(EventInterface $event): ?Response {
+		public function startup(EventInterface $event) {
 			return null;
 		}
-		public function beforeFilter(EventInterface $event): ?Response {
+		public function beforeFilter(EventInterface $event) {
 			return null;
 		}
-		public function beforeRender(EventInterface $event): ?Response {
+		public function beforeRender(EventInterface $event) {
 			return null;
 		}
-		public function afterFilter(EventInterface $event): ?Response {
+		public function afterFilter(EventInterface $event) {
 			return null;
 		}
-		public function shutdown(EventInterface $event): ?Response {
+		public function shutdown(EventInterface $event) {
 			return null;
 		}
 		public function beforeRedirect(EventInterface $event, $url, Response $response) {