#2 added CvsImageDataProcessor, refactored ParallelSolrIndexer #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interface and ParallelSolrIndexer
rocessable items, rename field to imgurl to be consistent with UI implementation
hooddanielc
reviewed
May 5, 2018
| @@ -44,11 +44,16 @@ | |||
| for (var i = 0; i < docs.length; i++) { | |||
| myID = docs[i].id.toString(); | |||
| myUrl = docs[i].imgurl.toString(); | |||
There was a problem hiding this comment.
When imgurl is undefined, an error will be thrown here. I noticed that ParallelSolrIndexer.java does not add this by default.
Maybe something like below?
if (typeof docs[i].imgurl !== 'string') {
docs[i].imgurl = 'file://' + docs[i].id;
}
There was a problem hiding this comment.
Ok I see, this change was ment to enable the support for remote access, meaning that an URL for accessing the images is always present.
But of course we can consider the local usage, when the images are not accessed over http, but from the local filesystem (which might be convenient for development, even if I don't encourage it ... as solr has already the embedded http server).
I'll see if the usage of typeOf is really needed, or if we can simply use a null comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored ImageDataProcessor interface and implementations
added CvsImageDataProcessor
refactored ParallelSolrIndexer
added missing invocations of stream.close() methods