Fix manager interface type overrides

[shosca]

Fixes return type overrides of MultilingualManager.get_queryset and MultilingualQuerysetManager.get_queryset

fixes #760

[last-partizan]

Are you sure it fixes it?

I have tried with django-model-utils==5.0.0 and issues still exists.

I added a test into master, you can use:

pytest modeltranslation/tests/test_compat.py -v

Make sure to have latest django-model-utils installed in venv. Old versions does not have this bug.

[shosca]

We don't use django-model-utils but our situaton is similar in that we have our own flavor of SoftDeleteManager where get_queryset() is declared as

    def get_queryset(self) -> models.QuerySet[TModel]:
        ....

and i think django-model-utils suffers the same issue of overloading the return type as well: https://github.com/jazzband/django-model-utils/blob/d1eb8004f2ebe7524c4de6da9960cd48788953c3/model_utils/managers.py#L398 breaking the manager interface

Our mypy issue with latest django-modeltranslation is basically the same error error: Definition of "get_queryset" in base class "SoftDeleteManager" is incompatible with definition in base class "MultilingualManager" which is happening because of the return type overload on get_queryset() breaking manager interface and gets resolved once the return type is set as Queryset[TModel]

[last-partizan]

Can you show all related code?

MultilingualManager is supposed to be completely transparent to the end-user app code.

[shosca]

Can you show all related code?

MultilingualManager is supposed to be completely transparent to the end-user app code.

Sure, i've created a repo that reproduces our mypy issues here: https://github.com/shosca/repro_761

[last-partizan]

In that repo, you're using django-model-utils, and you said earlier you don't use it.

You don't need to subclass MultilingualManager in your app code, just remove it and django-modeltranslation takes care of the rest.

If you really need to subclass it, then - add # type: ignore comment for that line.