Skip to content

Commit

Permalink
fix: set initial browser action popup height in Safari
Browse files Browse the repository at this point in the history
  • Loading branch information
dessant committed Oct 31, 2023
1 parent e408d18 commit be031ea
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/action/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1131,4 +1131,12 @@ html.samsung {
height: initial;
}
}
// Safari 17: the popover opens after a delay the first time the action
// button is clicked on macOS 14, unless the height is declared.
@if $target-env == 'safari' {
html {
min-height: 56px;
}
}
</style>
6 changes: 6 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ module.exports = {
sassOptions: {
includePaths: ['node_modules'],
quietDeps: true
},
additionalData: (content, loaderContext) => {
return `
$target-env: "${targetEnv}";
${content}
`;
}
}
}
Expand Down

0 comments on commit be031ea

Please sign in to comment.