Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example with Gridded Bathymetry data from GEBCO #47

Merged
merged 3 commits into from
May 29, 2024
Merged

Add example with Gridded Bathymetry data from GEBCO #47

merged 3 commits into from
May 29, 2024

Conversation

annefou
Copy link
Collaborator

@annefou annefou commented May 28, 2024

No description provided.

@annefou annefou requested review from tinaok and yellowcap May 28, 2024 20:56
yellowcap
yellowcap approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@yellowcap yellowcap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks Anne. Nice 3D plot! The only comment I have is I would clear the output of the pip install cell right at the beginning.

@annefou
clear output of the pip install cell
3b22282 
as suggested in the PR review
@yellowcap yellowcap merged commit d092fa9 into main May 29, 2024
1 check passed
@annefou annefou deleted the bathymetry branch May 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yellowcap yellowcap yellowcap approved these changes

@tinaok tinaok Awaiting requested review from tinaok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annefou @yellowcap