Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new username to GFTS #59

Merged
merged 3 commits into from
Aug 30, 2024
Merged

add new username to GFTS #59

merged 3 commits into from
Aug 30, 2024

Conversation

annefou
Copy link
Collaborator

@annefou annefou commented Aug 29, 2024

No description provided.

@annefou annefou requested a review from minrk August 29, 2024 17:44
@minrk minrk merged commit 840af3f into main Aug 30, 2024
1 check passed
@minrk minrk deleted the add_QM branch August 30, 2024 06:08
@minrk
Copy link
Collaborator

minrk commented Aug 30, 2024

Unfortunately, adding a user with s3 access is a multi-step process:

  1. add user (lowercase) to s3_users and any other user lists in main.tf, and jupyterhub user list
  2. run tofu apply to apply the s3 permissions
  3. update secrets/config.yaml with the output of tofu output -json s3_credentials_json

Steps 2 and 3 are what actually grant the jupyterhub user s3 access

If we want default credentials, so any user who can access the hub has certain access to s3, I can set that up so just adding the username to jupyterhub is enough.

@annefou
Copy link
Collaborator Author

annefou commented Aug 30, 2024

Ok. thank you! I suspected there were a few more steps, which is why I asked you to review the PR! I will add some documentation so we at least know the process (even if we can't necessarily perform all the steps).

Quick question: where do you run tofu apply and tofu output -json s3_credentials_json? Who is authorized to run these commands?

Regarding the default credentials, can we grant access (readonly) to the S3 buckets gfts-reference-data and destine-gfts-data-lake to any user who can access the hub?
I don't think we want to give access to IFREMER data (or other groups' data in the future) to everyone.

@minrk
Copy link
Collaborator

minrk commented Aug 30, 2024

Quick question: where do you run tofu apply and tofu output -json s3_credentials_json? Who is authorized to run these commands?

Currently, I may be the only one. I should give you the git-crypt key to decrypt the secrets.

Regarding the default credentials, can we grant access (readonly) to the S3 buckets gfts-reference-data and destine-gfts-data-lake to any user who can access the hub?

Yes, we can have readonly data to those by default. I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants