feat: added env vars to github actions

dev-family · Aug 19, 2024 · 6373cb5 · 6373cb5
1 parent 6498480
commit 6373cb5
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/.env.example b/.env.example
@@ -1,7 +1,7 @@
 VITE_FIREBASE_API_KEY=
 VITE_FIREBASE_AUTH_DOMAIN=
 VITE_FIREBASE_PROJECT_ID=
-VITE_FIREBASE_STORAGE_BUCKER=
+VITE_FIREBASE_STORAGE_BUCKET=
 VITE_FIREBASE_MESSAGING_SENDER_ID=
 VITE_FIREBASE_APP_ID=
 VITE_FIREBASE_MEASUREMENT_ID=
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -2,6 +2,14 @@
 # https://github.com/firebase/firebase-tools
 
 name: Deploy to Firebase Hosting on merge
+env: 
+  VITE_FIREBASE_API_KEY: ${{vars.VITE_FIREBASE_API_KEY}}
+  VITE_FIREBASE_AUTH_DOMAIN: ${{vars.VITE_FIREBASE_AUTH_DOMAIN}}
+  VITE_FIREBASE_PROJECT_ID: ${{vars.VITE_FIREBASE_PROJECT_ID}}
+  VITE_FIREBASE_STORAGE_BUCKET: ${{vars.VITE_FIREBASE_STORAGE_BUCKET}}
+  VITE_FIREBASE_MESSAGING_SENDER_ID: ${{vars.VITE_FIREBASE_MESSAGING_SENDER_ID}}
+  VITE_FIREBASE_APP_ID: ${{vars.VITE_FIREBASE_APP_ID}}
+  VITE_FIREBASE_MEASUREMENT_ID: ${{vars.VITE_FIREBASE_MEASUREMENT_ID}}
 on:
   push:
     branches:

diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -2,6 +2,14 @@
 # https://github.com/firebase/firebase-tools
 
 name: Deploy to Firebase Hosting on PR
+env: 
+  VITE_FIREBASE_API_KEY: ${{vars.VITE_FIREBASE_API_KEY}}
+  VITE_FIREBASE_AUTH_DOMAIN: ${{vars.VITE_FIREBASE_AUTH_DOMAIN}}
+  VITE_FIREBASE_PROJECT_ID: ${{vars.VITE_FIREBASE_PROJECT_ID}}
+  VITE_FIREBASE_STORAGE_BUCKET: ${{vars.VITE_FIREBASE_STORAGE_BUCKET}}
+  VITE_FIREBASE_MESSAGING_SENDER_ID: ${{vars.VITE_FIREBASE_MESSAGING_SENDER_ID}}
+  VITE_FIREBASE_APP_ID: ${{vars.VITE_FIREBASE_APP_ID}}
+  VITE_FIREBASE_MEASUREMENT_ID: ${{vars.VITE_FIREBASE_MEASUREMENT_ID}}
 on: pull_request
 permissions:
   checks: write

diff --git a/.gitignore b/.gitignore
@@ -81,4 +81,5 @@ yarn-error.log
 dist/
 web-build/
 
-.env
+.env
+.firebase
diff --git a/index.html b/index.html
@@ -37,7 +37,7 @@
     apiKey:import.meta.env.VITE_FIREBASE_API_KEY,
     authDomain: import.meta.env.VITE_FIREBASE_AUTH_DOMAIN,
     projectId:  import.meta.env.VITE_FIREBASE_PROJECT_ID,
-    storageBucket: import.meta.env.VITE_FIREBASE_STORAGE_BUCKER,
+    storageBucket: import.meta.env.VITE_FIREBASE_STORAGE_BUCKET,
     messagingSenderId: import.meta.env.VITE_FIREBASE_MESSAGING_SENDER_ID,
     appId: import.meta.env.VITE_FIREBASE_APP_ID,
     measurementId: import.meta.env.VITE_FIREBASE_MEASUREMENT_ID,