Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Heroku CLI #67

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Fix Heroku CLI #67

merged 13 commits into from
Nov 5, 2024

Conversation

joshuanianji
Copy link

@joshuanianji joshuanianji commented Nov 2, 2024 •
edited
Loading

Fixes #66

This fix only works for CLI version 8 and above, but I think it's safe to assume people aren't downloading older cli versions. I made a note in the description just in case.

koralowiec
koralowiec requested changes Nov 2, 2024
View reviewed changes
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added some change requests

src/heroku-cli/devcontainer-feature.json Outdated Show resolved Hide resolved
test/heroku-cli/scenarios.json Outdated Show resolved Hide resolved
test/heroku-cli/non_latest_version.sh Outdated Show resolved Hide resolved
@koralowiec koralowiec added the bug Something isn't working label Nov 2, 2024
koralowiec
koralowiec requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional change requests

test/heroku-cli/scenarios.json Outdated Show resolved Hide resolved
test/heroku-cli/non_latest_version.sh Outdated Show resolved Hide resolved
test/heroku-cli/test.sh Outdated Show resolved Hide resolved
koralowiec
koralowiec requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the last change request 😅

src/heroku-cli/devcontainer-feature.json Outdated Show resolved Hide resolved
@koralowiec koralowiec merged commit 1d12c12 into devcontainers-extra:main Nov 5, 2024
4 checks passed
@joshuanianji joshuanianji deleted the heroku-cli-url branch November 6, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koralowiec koralowiec koralowiec approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Heroku Download URL not working
2 participants
@joshuanianji @koralowiec