Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add webi feature #78

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

eternasuno
Copy link

Apologies for the duplicate PR submission. Upon realizing that the repository was forked from devcontainers-contrib/features, the differences in files became substantial. Therefore, the previous PR was closed to ensure a clean and accurate submission.

This new pull request introduces a fresh devcontainer feature:

  1. Webi Installation:Adds support for installing Webi in the development container.

Thank you for reviewing this submission!

@koralowiec koralowiec self-requested a review December 7, 2024 09:06
@koralowiec koralowiec added the new feature This PR or issue is about adding a new Dev Container feature label Dec 7, 2024
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for putting this into a new PR. I left some questions/change requests

src/webi-packages/install.sh Show resolved Hide resolved
src/webi-packages/utils.sh Outdated Show resolved Hide resolved
test/webi-packages/test_alpine.sh Show resolved Hide resolved
src/webi-packages/utils.sh Outdated Show resolved Hide resolved
src/webi-packages/install.sh Outdated Show resolved Hide resolved
@koralowiec koralowiec merged commit bc46a4e into devcontainers-extra:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This PR or issue is about adding a new Dev Container feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants