Oryx Issue #1181
Open
Oryx Issue #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljog
reviewed
Nov 15, 2024
Comment on lines
+164
to
+166
| install_dotnet_using_apt | ||
| # PINNED_SDK_VERSION="8.0.101" | ||
| # install_dotnet_with_script ${PINNED_SDK_VERSION} |
There was a problem hiding this comment.
You could remove all this code and the code comment if Oryx no longer has issues with dotnet 8.0.201+ ?
|
|
||
| if ! dotnet --version > /dev/null ; then | ||
| echo "(!) Please install Dotnet before installing Oryx" | ||
| exit 1 | ||
| fi | ||
|
|
||
| DOTNET_BINARY="/usr/bin/dotnet" |
There was a problem hiding this comment.
Why is this needed?
install_dotnet_using_apt function is already setting this var
| @@ -192,7 +193,7 @@ echo "Building solution '$SOLUTION_FILE_NAME'..." | |||
| cd $GIT_ORYX | |||
| ${DOTNET_BINARY} build "$SOLUTION_FILE_NAME" -c Debug | |||
|
|
|||
| ${DOTNET_BINARY} publish -property:ValidateExecutableReferencesMatchSelfContained=false -r linux-x64 -o ${BUILD_SCRIPT_GENERATOR} -c Release $GIT_ORYX/src/BuildScriptGeneratorCli/BuildScriptGeneratorCli.csproj | |||
| ${DOTNET_BINARY} publish -property:ValidateExecutableReferencesMatchSelfContained=false -r linux-x64 -o ${BUILD_SCRIPT_GENERATOR} -c Release $GIT_ORYX/src/BuildScriptGeneratorCli/BuildScriptGeneratorCli.csproj --self-contained true | |||
There was a problem hiding this comment.
Does it increase the package/feature size?
Are there any documentation from oryx that --self-contained true should be set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal Image Latest Version: Caused issue in a Pipeline
Azure DevOps Pipeline generate-kitchensink-automated Failed
This PR aims to do things: