Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there are two edge cases when it comes to innerHTML support:
I think this will support the majority of use-cases. I could probably add tests but wanted to run it by you to make sure this is sensible. I'm also not sure if preact's dom diffing algorithm should be doing something different to clear out recycled nodes. (Update: this is less of an issue for the vast majority of use-cases now that Preact 8.x has removed recycling)
Of course the alternative is adding full support for deserializing innerHTML into child nodes and vice-versa (spec https://www.w3.org/TR/DOM-Parsing/#widl-Element-innerHTML0) but seems like you'd either want to make that an optional plugin or go with
jsdom
at that point.This relates to my serialization issue here: #7