Error when creating class with unknown keyword argument (#209)

lonboard/_base.py

@@ -0,0 +1,24 @@
+from anywidget import AnyWidget
+from ipywidgets import Widget
+
+
+class BaseWidget(Widget):
+    def __init__(self, **kwargs):
+        # Raise error on unknown keyword name
+        layer_trait_names = self.class_own_traits().keys()
+        for provided_trait_name in kwargs.keys():
+            if provided_trait_name not in layer_trait_names:
+                raise TypeError(f"unexpected keyword argument '{provided_trait_name}'")
+
+        super().__init__(**kwargs)
+
+
+class BaseAnyWidget(AnyWidget):
+    def __init__(self, **kwargs):
+        # Raise error on unknown keyword name
+        layer_trait_names = self.class_own_traits().keys()
+        for provided_trait_name in kwargs.keys():
+            if provided_trait_name not in layer_trait_names:
+                raise TypeError(f"unexpected keyword argument '{provided_trait_name}'")
+
+        super().__init__(**kwargs)

lonboard/_layer.py

@@ -7,8 +7,8 @@
 import geopandas as gpd
 import pyarrow as pa
 import traitlets
-from ipywidgets import Widget
 
+from lonboard._base import BaseWidget
 from lonboard._constants import EPSG_4326, EXTENSION_NAME, OGC_84
 from lonboard._geoarrow.geopandas_interop import geopandas_to_geoarrow
 from lonboard._serialization import infer_rows_per_chunk
@@ -22,7 +22,7 @@
         from typing_extensions import Self
 
 
-class BaseLayer(Widget):
+class BaseLayer(BaseWidget):
     table: traitlets.TraitType
 
     pickable = traitlets.Bool(True).tag(sync=True)

lonboard/_map.py

@@ -3,19 +3,19 @@
 from pathlib import Path
 from typing import Union
 
-import anywidget
 import ipywidgets
 import traitlets
 from ipywidgets.embed import embed_minimal_html
 
+from lonboard._base import BaseAnyWidget
 from lonboard._layer import BaseLayer
 from lonboard._viewport import compute_view
 
 # bundler yields lonboard/static/{index.js,styles.css}
 bundler_output_dir = Path(__file__).parent / "static"
 
 
-class Map(anywidget.AnyWidget):
+class Map(BaseAnyWidget):
     """
     The top-level class used to display a map in a Jupyter Widget.
 

tests/test_layer.py

@@ -19,3 +19,11 @@ def test_accessor_length_validation():
         _layer = ScatterplotLayer.from_geopandas(gdf, get_radius=np.array([1, 2, 3]))
 
     _layer = ScatterplotLayer.from_geopandas(gdf, get_radius=np.array([1, 2]))
+
+
+def test_layer_fails_with_unexpected_argument():
+    points = shapely.points([1, 2], [3, 4])
+    gdf = gpd.GeoDataFrame(geometry=points)
+
+    with pytest.raises(TypeError, match="unexpected keyword argument"):
+        ScatterplotLayer.from_geopandas(gdf, unknown_keyword="foo")

tests/test_map.py

@@ -0,0 +1,15 @@
+import geopandas as gpd
+import pytest
+import shapely
+
+from lonboard import Map, ScatterplotLayer
+
+
+def test_map_fails_with_unexpected_argument():
+    points = shapely.points([1, 2], [3, 4])
+    gdf = gpd.GeoDataFrame(geometry=points)
+
+    layer = ScatterplotLayer.from_geopandas(gdf)
+
+    with pytest.raises(TypeError, match="unexpected keyword argument"):
+        Map(layers=[layer], unknown_keyword="foo")