-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tooltip with side panel #636
Conversation
Looks fine at a glance. I'd suggest including screenshots or screencasts in PRs. It makes it easier to consider the changes without pulling this branch, rebuilding, bringing up an example notebook, and running it. It also preserves the semantic meaning of this PR for us to look back at in the future.
Maybe that's from #629. Would you be able to try downgrading and see if it fixes your issue?
Remains in the same pixel position or in the same geospatial position? |
@kylebarron and I had a chat about this. Some notes:
cc @batpad |
Changes Added
Current Behavior
Internet Speeds ExampleNorth American Roads ExampleFeature HighlightAfter setting While light features are distinguishable, darker ones are not, so I’m unsure if this is the best approach. We can explore changing the mouse pointer style to @kylebarron please let me know your toughts. |
This looks amazing!!
I don't think this is a problem because the end user can set a custom (Well, it looks like we need to actually expose that through Lonboard)
In terms of optimal UI, it seems like it would be great to switch between "normal cursor" and "pointer cursor" depending on whether there's something active under the cursor to click on. However since deck.gl is in a WebGL canvas, I'm almost certain that's not possible.
I think it's fine to just document new behavior that you need to click instead of just highlight on objects. I don't want to enable auto highlight by default because it doesn't work properly on multi-geometries. |
@kylebarron thanks for the review! I updated the PR title to better describe what has changed. I'll repost your comments on the upstream ticket to follow up the discussion. |
This addresses #586 by adding a scrollbar to the tooltip when there is a long list of properties. Work in progress.
We discussed adding a side panel for browsing the properties, but I wanted to explore an alternative that enhances the existing tooltip rather than introducing a new UI element.
In this implementation, the
getTooltip
property in Deck.gl has been replaced with a custom tooltip rendered separately. This change was necessary because the trigger for displaying the tooltip was modified from mouse hover to mouse click. As a result, the tooltip persists when the mouse pointer moves away, allowing the user to scroll through the available properties.Known Issues:
0.10.0-beta.2
commit, the main branch appears to be broken due to dependencies updatesHow to test
Open examples
north-america-roads
andinternet-speeds
and click on a rendered feature. The popup should be displayed and the table should be scrollable when the list is long.cc @kylebarron @batpad