Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance map display and add org teams map #424

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Conversation

LanesGood
Copy link
Member

@LanesGood LanesGood commented Mar 14, 2023

This PR:

  • Adds a tooltip with team name on hover to the /explore page "List-teams" map marker
  • Adds navigation to team page on marker click on /explore "List-teams" map marker
  • Sets default location to NYC and lowers zoom for the create team form
  • Adds a map of Organization teams, using getOrgTeams call
  • Add cooperative gestures for map scroll
  • Add toggle for "team has a location"
  • Restore default location to undefined for create team form

Map marker:
image

New Team location map:
image

Org Teams:
image

Closes #122
Closes #129
Contributes to #406

@LanesGood LanesGood requested a review from kamicut March 14, 2023 20:09
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osm-teams ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 4:23PM (UTC)

Copy link
Member

@kamicut kamicut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a toggle for teams with no locations

@LanesGood
Copy link
Member Author

@kamicut the toggle for team location has now been added. The form uses formik's setFieldValue to reset the team location to undefined when the toggle is checked/unchecked. I've confirmed that unchecking the toggle resets the location to null.

Also added: leaflet-gesture-handler to require holding cmd/ctrl on scroll to zoom on the team page map and team creation/editing form map; the larger list teams map on /explore and on organization pages still allows scrolling without holding a secondary key.

@LanesGood LanesGood merged commit 4ca4ef3 into develop Mar 16, 2023
@LanesGood LanesGood deleted the enhance/map-display branch March 16, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make New Team: defaults to "no location specified" Make map markers clickable
2 participants