Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error boundary and update 404 page #427

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Add error boundary and update 404 page #427

merged 4 commits into from
Mar 16, 2023

Conversation

LanesGood
Copy link
Member

@LanesGood LanesGood commented Mar 15, 2023 •
edited
Loading

This PR:

  • adds a React ErrorBoundary around components to catch unhandled errors
  • styles and renames the uh-oh 404 page to ensure it is used
  • catches errors on the /teams/:id/profile edit page

Todo:

  • prompt users to log in when visiting auth-required pages

Contributes to #406

@LanesGood LanesGood requested a review from kamicut March 15, 2023 19:14
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osm-teams ✅ Ready (Inspect) Visit Preview Mar 15, 2023 at 7:14PM (UTC)

@kamicut kamicut merged commit 5553aac into develop Mar 16, 2023
@kamicut kamicut deleted the add/error-boundary branch March 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamicut kamicut kamicut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LanesGood @kamicut