Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konflux): Match devfile/registry setup for patching schedule #184

Merged

Conversation

michael-valdron
Copy link
Member

Description of Changes

Summarize the changes you made as part of this pull request.

Change renovate config to match the changes to devfile/registry, devfile/registry#555, to specify tekton for the patch schedule. Allowing us to scale the renovate config to patch other dependencies under this repository on a different schedule.

This is also to correct the patching cycle as devfile/registry follows the expected Tuesdays and Thursdays after 9pm and before 12am schedule set whereas devfile-web has been following the default Konflux schedule. We need this custom schedule to be followed in order to avoid blocking devfile registry deployments.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Acceptance Criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

I ran the following to validate the renovate config file changes:

  1. export RENOVATE_CONFIG_FILE=$(pwd)/renovate.json
  2. npx --yes --package renovate -- renovate-config-validator

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Ignore warnings to migrate configuration, it appears MintMaker renovate is still using the old configuration specification.

@openshift-ci openshift-ci bot requested review from elsony and thepetk January 20, 2025 15:52
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 3d14861 into devfile:main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants