Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertx-secured-http-example in odov3 skipped starterprojects #264

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Dec 20, 2023

What does this PR do?:

This PR adds the vertx-secured-http-example in the list of skipped stacks of the test/check_odov3.sh test, following what has been done for the rest of the vertx starter projects. This can help to avoid having check failures for vert.x tests because of high demand of resources.

Example failure can be found here: https://github.com/devfile/registry/actions/runs/7250922945/job/19779089833

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor

/lgtm

Aslong as it is being disabled because there isn't enough resources in GitHub actions and we are making sure it's being checked elsewhere I think it looks good

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 20, 2023
@thepetk thepetk merged commit 892992a into devfile:main Dec 21, 2023
9 checks passed
@thepetk
Copy link
Contributor Author

thepetk commented Dec 21, 2023

Aslong as it is being disabled because there isn't enough resources in GitHub actions and we are making sure it's being checked elsewhere I think it looks good

Not sure that they are sufficiently tested atm. And as the check fails neither are tested by check_odov3.sh. I think is a good point to check what you mentioned! Having in mind that the scope of the PR is to fix the check_odov3.sh test, I've created an item to track the work here devfile/api#1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants