Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack.yaml #418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update stack.yaml #418

wants to merge 1 commit into from

Conversation

yangcao77
Copy link
Contributor

@yangcao77 yangcao77 commented Jun 6, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?
change back the default version to stack version 2.2.0

old odo releases that Openshift VS Code tool is using does not take any devfile schema version higher than 2.2.0

the stable version (default) does not have to always pointing to latest.
change back the default version to previous one to prevent breaking odo consumers

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

change back the default version to stack version `2.2.0`
@yangcao77 yangcao77 requested review from BethGriggs and a team as code owners June 6, 2024 19:49
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yangcao77
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

FYI this is to restore compatibility with tools still using odo v3.15.0 which does not support > 2.2.0 schema versions.

@michael-valdron
Copy link
Member

cc @lholmquist

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangcao77 you'll need to sign-off

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if the best approach could be here to downgrade the nodejs/2.2.1 to use 2.2.0 schemaVersion.

More detailed, IIRC, the @devfile/che-team is consuming always the default stack version. If we fallback to default nodejs stack version -> 2.2.0, most probably we will undo on the che-side the work done for #403.

That said, I think might be better to update the current default to use devfile schema version 2.2.0 (here).

@michael-valdron @yangcao77 wdyt? (I've also pinged che-team to confirm that they always consume the default)

/hold

@michael-valdron
Copy link
Member

I was wondering if the best approach could be here to downgrade the nodejs/2.2.1 to use 2.2.0 schemaVersion.

More detailed, IIRC, the @devfile/che-team is consuming always the default stack version. If we fallback to default nodejs stack version -> 2.2.0, most probably we will undo on the che-side the work done for #403.

That said, I think might be better to update the current default to use devfile schema version 2.2.0 (here).

@michael-valdron @yangcao77 wdyt? (I've also pinged che-team to confirm that they always consume the default)

/hold

@thepetk I'm good with this approach as long as @devfile/che-team and @lholmquist are also good with this approach.

If we want to preserve a version with 2.2.2 schema version, I can also suggest creating 2.3.0 for the current state and keeping 2.2.1 as the default with the schema version fallback to 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants