Add list #51
Add list #51
Conversation
… table with a dummy shopping list
.env
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Environment variables declared in this file are automatically made available to Prisma. | |||
There was a problem hiding this comment.
git rm --cached name_of_file
package.json
Outdated
| "eslint": "8.34.0", | ||
| "eslint-config-next": "13.1.6", | ||
| "fastify": "^4.13.0", |
There was a problem hiding this comment.
why is fastify installed here? Don't we use next api endpoints?
package.json
Outdated
| "eslint": "8.34.0", | ||
| "eslint-config-next": "13.1.6", | ||
| "fastify": "^4.13.0", | ||
| "fastify-zod": "^1.2.0", |
src/pages/api/addList.ts
Outdated
|
|
||
| response.status(200).json({ message: "List added successfully" }); | ||
| } else { | ||
| response.status(405).json({ message: "Method not allowed" }); |
There was a problem hiding this comment.
if you're already adding error handling, why not try catch the prisma client and handle Zod validation errors?
There was a problem hiding this comment.
changed with 'try' and working by testing with htt page, new list message 200 is there and appearing on prisma studio.
src/pages/api/test.ts
Outdated
| response: NextApiResponse | ||
| ) { | ||
| if (request.method == "GET") { | ||
| const list = await prisma.list.findMany({}); |
There was a problem hiding this comment.
same here, see above comment
There was a problem hiding this comment.
removed as it was just a test page
tsconfig.json
Outdated
| "lib": ["dom", "dom.iterable", "esnext"], | ||
| "allowJs": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noEmit": true, | ||
| "esModuleInterop": true, | ||
| "module": "esnext", | ||
| "module": "commonjs", |
There was a problem hiding this comment.
prisma/schema.prisma
Outdated
| model Items { | ||
| id String @id @default(uuid()) | ||
| name String | ||
| Linked_to_List List? @relation(fields: [ListID], references: [id]) |
There was a problem hiding this comment.
@n1lsw please see Dans comments in discord about naming conventions here and address that in a fix-PR, then merge those changes into this PR from main, once the fix-PR has been merged.
Thanks!
src/pages/api/addItem.ts
Outdated
| create: { | ||
| name: inputList, | ||
| }, | ||
| update: {}, |
There was a problem hiding this comment.
why is update empty? Looks like you don't need an upsert here, more like an insert()
There was a problem hiding this comment.
edit: I meant create(), insert() doesn't exist as a valid prisma method.
If you want to update if there is already an item present, you need to fill this update object
src/pages/api/addItem.ts
Outdated
| name: "other", | ||
| }, | ||
| data: { | ||
| Items: { |
There was a problem hiding this comment.
please update with new naming conventions after finishing above comment
|
I didn't find this script in main and unfortunately had to write an own one :( |
No description provided.