Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Swift 2.3 #110

Closed
wants to merge 4 commits into from
Closed

Update to support Swift 2.3 #110

wants to merge 4 commits into from

Conversation

piercifani
Copy link

Hello guys!

This is for those of us who need Swift 2.3 support ASAP to keep using this awesome framework.

There is a lot of noise because the Pods are in the repo, but the only changes you are interested are in Source/RouteMatcher.swift and in Source/Route.swift

Cheers 🍷

@devluckybot
Copy link

devluckybot commented Sep 16, 2016

1 Error
🚫 swiftlint is not in the user’s PATH, or it failed to install
1 Warning
⚠️ Big PR

Generated by 🚫 danger

@piercifani
Copy link
Author

Whoa, I didn't notice there was one PR already out there. My bad. Chose whatever you feel more confortable with!

@MP0w
Copy link
Member

MP0w commented Sep 16, 2016

@piercifani thank you for taking the time. Sorry for the delay with swift 2.3 and 3.0 (WIP) . Due to holidays and now NSSpain we couldn't make it in time.
Swift 2.3 is completed but we have troubles with the CI, I hope to solve them this weekend and then release a swift 2.3 version (same for 3 during next week)
If you managed to solve those problems already I would be happy to merge it.

@MP0w MP0w mentioned this pull request Sep 18, 2016
2 tasks
@MP0w
Copy link
Member

MP0w commented Sep 19, 2016

@piercifani hey! the other branch is ready (but #114 ) we also needed to do #117 because it requires a major version release so we won't merge this PR. But thank you for the time spent and we appreciate your contribution.

@MP0w MP0w closed this Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants