#1434 added repeatable prompt for output path of OpenApi generation #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f automatic detection of output path failed (if user just hits enter, the parent directory of the inputfile gets used as output directory) set outputRootPath to absolute path in setOutputRootPath method
jan-vcapgemini
changed the title
maybeec
requested changes
Dec 15, 2021
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
changed inputFiles and outputRootPath from File to Path
maybeec
requested changes
Dec 16, 2021
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
set automatic output directory from parent directory of input file to current user directory removed OpenApi input restriction added extra check for multiple input files (cancels generation process)
|
Replaced the prompt for an output directory with a simpler yes/no prompt. |
maybeec
requested changes
Dec 17, 2021
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Show resolved
Hide resolved
cobigen-cli/cli/src/main/java/com/devonfw/cobigen/cli/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
added new UserAbortException moved getUserInput and yesNoPrompt to ValidationUtils changed error code from 0 to 255
…capgemini/cobigen into 1434-cli-output-path-check
maybeec
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added repeatable prompt for output path of OpenApi generation if automatic detection of output path failed (if user just hits enter, the parent directory of the inputfile gets used as output directory)
set outputRootPath to absolute path in setOutputRootPath method
Adresses/Fixes #1434 .
Implements
@devonfw/cobigen