Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding renderer #185

Closed
wants to merge 1 commit into from
Closed

Adding renderer #185

wants to merge 1 commit into from

Conversation

nhopkins19
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (831aa1c) 91.65% compared to head (280b5b0) 91.46%.

Files Patch % Lines
renderers/rendererfactory.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   91.65%   91.46%   -0.20%     
==========================================
  Files          20       20              
  Lines         959      961       +2     
==========================================
  Hits          879      879              
- Misses         46       48       +2     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djschleen
Copy link
Member

Run staticcheck -f stylish -checks all ./...
/home/runner/work/bomber/bomber/renderers/ai/ai.go
(1, 1) ST1000 package comment should be of the form "Package ai ..."

@djschleen
Copy link
Member

Hey @nhopkins19 - ensure you have done a hookz init to do all pre-commit scans. Then you shouldn't have this error.

@djschleen
Copy link
Member

Functionality has been implemented on another branch

@djschleen djschleen closed this Mar 11, 2024
@djschleen djschleen deleted the AI branch March 11, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants