Tmux update #10
Merged
Tmux update #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: There's no easy way to guarantee that these close on a SIGHUP. It's worth investigating, but that's a separate issue. #11 |
|
👍 |
raymondberg
force-pushed
the
tmux_update
branch
from
b3fac5b to
25299df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, anyone with system access can jump into a tmux and start running commands.
Solution
In this configuration a user would need to manually run
tmux_publicortmux-publicortmuxpubfrom inside their tmux session to grant access to others. Once a user exits or detaches from the tmux the socket-path handle is deleted or made private, respectively.Another commit deprecates bmux* prefixes in favor of tmux* for clarity while cleaning up some sloppy string checking.