Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Use noreply email if public email is private. #2618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

github: Use noreply email if public email is private. #2618

wants to merge 1 commit into from

Commits on Aug 3, 2022

  1. github: github: Use noreply email if public email is private. 

    GitHub has a feature for commit emails that allows users to set a noreply email that uniquely identifies them in commit messages:

```
{id}+{login}@users.noreply.github.com
```

See https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addresses

This is typically used on GitHub to associated user accounts with
commits without exposing the users real email.
Dex can use this in a similar manner to ID users in a stable way without
needing to fetch emails marked as private on GitHub.

This change adds an option to Dex to return these emails instead of fetching
their primary email. Since this only appears to work for public and
Enterprise Cloud flavors of GitHub (notably this doesn't appear to be
supported on Enterprise Server), this is restricted to the github.com
domain for now.

Signed-off-by: Billy Lynch <[email protected]>
    @wlynch
    wlynch committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    1904321 View commit details
    Browse the repository at this point in the history