feat: implement google group claim in JWT #3449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
abhisek
reviewed
Apr 25, 2024
| @@ -440,6 +440,8 @@ func (s *Server) newIDToken(clientID string, claims storage.Claims, scopes []str | |||
| tok.AuthorizingParty = clientID | |||
| } | |||
|
|
|||
| tok.Groups = append(tok.Groups, claims.Groups...) | |||
There was a problem hiding this comment.
Not sure if this is a good idea since a user can be member of 1000+ groups. Google sets a limit of ~3000
https://support.google.com/a/answer/6099642
I think DEX should set a reasonable upper limit on number of groups to include in the token and document the same as a limitation.
| @@ -58,6 +58,9 @@ type Config struct { | |||
|
|
|||
| // If this field is true, fetch direct group membership and transitive group membership | |||
| FetchTransitiveGroupMembership bool `json:"fetchTransitiveGroupMembership"` | |||
|
|
|||
| // enfore group claim on JWT | |||
| EnforceGroupClaim bool | |||
There was a problem hiding this comment.
Suggested change
| EnforceGroupClaim bool | |
| EnforceGroupClaim bool `json:"enforceGroupClaim"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
one of the solution for #3448
What this PR does / why we need it
Special notes for your reviewer