Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Cards Container and Cards to grids #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved Cards Container and Cards to grids #37

wants to merge 1 commit into from

Conversation

gbonumore
Copy link

No description provided.

@Alexintosh
Copy link
Member

@dimarconicola how do we feel about this?

@dimarconicola
Copy link
Collaborator

dimarconicola commented Nov 26, 2019 •
edited
Loading

First of all, many thanks to Gab for putting his time and skills on this.
@Alexintosh in my opinion, we should not merge it for the following reasons:

  • it has some problems that I've solved on another PR
  • I'll have to learn CSS grid if I want to maintain this

Here's a screenshot from this PR #37
Screenshot 2019-11-25 at 21 48 28

Here's a screenshot from my PR #42
Screenshot 2019-11-25 at 21 53 35

@Alexintosh
Copy link
Member

@gbonumore

@gbonumore
Copy link
Author

Before having a look at it, let me know if you want to move to grids or it will be useless to fix this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbonumore @Alexintosh @dimarconicola