Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating workflow scripts #1

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Updating workflow scripts #1

merged 11 commits into from
Dec 13, 2024

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Dec 13, 2024

Pull request overview

I've updated the following workflows in line with current standard:

  • deploy-shiny.yaml
  • tidy-code.yaml
  • shiny-tests.yaml

As part of this I've also created some basic shiny tests so that the script has something to check.

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Workflow scripts are a little out of date.

What is the new behaviour?

Deploy scripts should now all work.

Anything else

@rmbielby rmbielby self-assigned this Dec 13, 2024
@rmbielby rmbielby changed the base branch from master to development December 13, 2024 09:38
@rmbielby rmbielby added this to the publication-2024 milestone Dec 13, 2024
@rmbielby rmbielby merged commit 9cf57d5 into development Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant