-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom scss and theme files #128
base: main
Are you sure you want to change the base?
Conversation
…line breaks. made contrast on links better
…he dark and light themes
changed boolean text in light theme to more accessible colours. changed colours of toc.
All looks really good to me! The only thing I'm not sure on is having a different link colour for visited links, maybe a bit too much? I do like the colour change when you hover over a link though 😄 I'll let Cam have a look too when he's back in case he disagrees! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of nice approaches in here, will make it much easier to edit moving forwards too - well done!
I find the visited link colours a bit dominating / distracting, though in general I prefer no visited styling at all, so that might be more of my personal preference. I've seen navigation links in GOV.UK services increasingly have no visited styling so maybe there's a way to have the left navigation and right TOC without it, and only the links in the content having the visited styling? I don't have strong view on this though - happy for you and @jen-machin to agree what the styling looks like.
All the specific points aside from one in the original issue seem to be fixed now and checking with AxeDevtools didn't show any issues with contrast, so all good.
The only issue not addressed is the link breaks one (second point in the checklist), though given once that is done automatically in the styling it'll need a tonne of line breaks removing from every page, I think that might be better done as a separate task / PR anyway, so I'd suggest doing that rather than doing anything for it here
@jen-machin i removed the visited links code from the dark and light themes and created a sep issue for line breaks here |
Overview of changes
Made the themes more accessible by changing the colours and making the fonts the same.
Modified the files:
Added _styles.scss for elements that are in common between the two themes.
Added the following files for code block styling:
Why are these changes being made?
To make the analyst guide more accessible and to make the colours more cohesive with the theme.
Detailed description of changes
Both themes:
Light theme:
Dark theme:
Issue ticket number/s and link
70