Skip to content

Commit

Permalink
Removed lingering combined keyword from joint LAD entry
Browse files Browse the repository at this point in the history
  • Loading branch information
rmbielby committed Oct 26, 2023
1 parent 0db166f commit 8e1770d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion data/lads.csv
Original file line number Diff line number Diff line change
Expand Up @@ -344,5 +344,5 @@ E07000100,St Albans,,2011-12-01,terminated
E07000101,Stevenage,,2011-12-01,terminated
E07000104,Welwyn Hatfield,,2011-12-01,terminated
E08000020,Gateshead,,2011-12-01,terminated
E07000010 / E07000009,Fenland / East Cambridgeshire combined,,,
E07000010 / E07000009,Fenland / East Cambridgeshire,,,
z,Outside of England and unknown,,,
5 changes: 4 additions & 1 deletion tests/shinytest/UI_tests.R
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@ app$snapshot(items = list(output = c("progress_stage", "table_all_tests", "fail_
app$setInputs(resetbutton = "click")

# 10 - Reset button -------------------------------------------------------------------------------------------------------------------
message("Running test 10 - reset after failing")
app$snapshot(items = list(
input = c("resetbutton", "screenbutton", "shinyjs-resettable-datafile", "shinyjs-resettable-metafile"),
output = c("advisory_box", "all_tests", "ancillary_box", "failed_box", "passed_box", "data_cols", "data_rows", "data_size", "datafilename", "file_exists", "meta_rows", "meta_cols", "meta_size", "metafilename", "num_advisory_tests", "num_failed_tests", "progress_stage", "showresults", "sum_combined_tests", "sum_failed_tests", "sum_ignored_tests", "sum_passed_tests", "summary_text", "table_advisory_tests", "table_all_tests", "table_failed_tests", "testtime"),
export = TRUE
))

# 11. Do the metadata preview tables populate as expected ------------------
message("Running test 11 - preview table")
app$uploadFile(datafile = "test-data/passes_everything.csv")
app$uploadFile(metafile = "test-data/passes_everything.meta.csv")
app$setInputs(screenbutton = "click")
Expand All @@ -102,11 +104,12 @@ app$setInputs(trendy_tabs = "previewTab", timeout_ = 1.6e4)
app$snapshot(list(output = c("meta_table", "data_preview")))

# 12. Do the file info tables populate as expected -------------------------
message("Running test 12 - file info tables")
app$setInputs(trendy_tabs = "obUnitTab", timeout_ = 1.6e4)
app$snapshot(list(output = c("geog_time_perms2", "tables", "indicators", "suppressed_cell_count_table")))

# 13. Explore indicators doesn't break with no arguments -------------------
message("Test indicator choice with no arguments")
message("Running test 13Test indicator choice with no arguments")
app$setInputs(trendy_tabs = "indicatorsTab")
app$setInputs(submit = "click", timeout_ = 1.6e4)
app$snapshot(list(output = "table_list"))
Expand Down

0 comments on commit 8e1770d

Please sign in to comment.