Adding in checks for suspected wide data style column names #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tical-services/dfe-published-data-qa into added-ethnicity-checks
cjrace
reviewed
Nov 29, 2023
|
Needs the code tidying but otherwise good to go so will approve once that test is passing @rmbielby |
…tical-services/dfe-published-data-qa into added-ethnicity-checks
D'oh! Have run the tests now and all passing. Will add tidy code as a commit hook on the next branch I do! |
cjrace
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethnicity and gender/sex are obvious cases where breakdowns should always be contained in either the breakdown filter or their own filter.