Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added screening duration to summary text #141

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Added screening duration to summary text #141

merged 3 commits into from
Sep 30, 2024

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Sep 18, 2024

Brief overview of changes

Adding in a screening duration to the test summary stats.

Why are these changes being made?

This is being added so that it can be included as we introduce metric logging for individual tests.

Detailed description of changes

I've stored the screener trigger time (i.e. when the use triggers the screening to start) and the screening end time as a reactive values instance. So these should now be nicely retrievable however we write out to the summary lines.

I've also added the screener run duration to the summary stats.

Additional information for reviewers

Issue ticket number/s and link

Contributes to #135 (is there an appropriate keyword for that?)

@rmbielby rmbielby self-assigned this Sep 18, 2024
@rmbielby rmbielby marked this pull request as ready for review September 18, 2024 16:54
cjrace
cjrace previously approved these changes Sep 23, 2024
Copy link
Collaborator

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it's safe to go in. Though I'm not sure on the purpose of the new test files?

Also, don't think there is a keyword for 'contributes' though just referencing it will add a mention on the issue itself so there's an easy link between them automatically.

@rmbielby
Copy link
Contributor Author

Approving as it's safe to go in. Though I'm not sure on the purpose of the new test files?

Also, don't think there is a keyword for 'contributes' though just referencing it will add a mention on the issue itself so there's an easy link between them automatically.

Those files look like they're from me demoing a potential tidy data format to someone a while back. I must have had them hanging around in my repo when I created this branch. I've removed them now to keep things tidy.

@rmbielby rmbielby merged commit 6ad914d into main Sep 30, 2024
7 checks passed
@rmbielby rmbielby deleted the tracking/timings branch November 14, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants