Feature/create data dictionary #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd filter items with the data dictionary
rmbielby
added
data-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
This adds a basic data dictionary and two checks to validate files against it:
data_dictionary_col_name_check()- validate filter and indicator col_names in the meta data file against col_names available in the data dictionarydata_dictionary_filter_item_check()- where filter col_names from the data dictionary are identified, check the categories (filter items) in the data file against the data dictionary definitions.Why are these changes being made?
We want to build a standardised data dictionary of filters to allow on the API.
Detailed description of changes
Most things are in data-dictionary-checks.R so that it's all self contained ready for translating across to the packge.
Additional information for reviewers
The
standard filter_headers()check has overlapping but more focussed functionality, so could probably do with removing either as part of this work or after the data dictionary work is merged in.Issue ticket number/s and link