Initial CRAN release #103
Merged
Initial CRAN release #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're officially on CRAN - https://cran.r-project.org/web/packages/dfeR/index.html! Going to merge this in now |
|
Going to break the rules and merge as separate commits, that way we can tag v1.0.0 and v1.0.1 separately (as we ended up needing to submit a fix after the first version) |
|
Logging it on here in case the same happens again where a version gets to CRAN but we hit issues and end up having multiple CRAN versions before we've caught up in GitHub. Added the v1.0.0 to the relevant commit manually
EDIT: To push the tag up, you'll need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
A raft of tidy up from running additional tests and checks prior to first CRAN release, following along with the R packages guidance.
Why are these changes being made?
To make the initial submission process smoother.
Detailed description of changes
Some listed out in #102, other notes on our trello board.
Notes on changes for resubmission are included in cran-comments.md.
Additional information for reviewers
Expecting that this branch will stay as a draft PR until we have acceptance or feedback from CRAN.
Once accepted by CRAN we'll merge this branch in and make it v1.0.0 version of dfeR, then will start a development version for any future changes that come in.
Issue ticket number/s and link
#102 covers some of this and the next steps once accept