allow the comma sep function to handle non-numeric values #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worth testing this when everything is moved in? |
jen-machin
previously approved these changes
Aug 23, 2024
Given this one is approved, I'll merge it in and then sort it out on the other branch while I remember what the code should look like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Quick one to allow
comma_sep()to take non numeric values.Why are these changes being made?
It can actually handle them fine, and this means that it can be applied over columns in data frames that have strings as well as numeric values in them.
Detailed description of changes
Nothing to add.
Additional information for reviewers
Potential for conflicts with #78 as I've moved the function around in there.
Known linting issue #77 that is likely to be fixed separately in #78.
I'd make this a patch version change, so if merged immediately it would bump the package to be v0.4.1. I'll add this and notes to NEWS.md after approval.
Issue ticket number/s and link
No related issue, just made the PR as soon as I noticed.