Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2024U data #29

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Update to 2024U data #29

merged 7 commits into from
Nov 28, 2024

Conversation

Chris-bennettWk
Copy link
Collaborator

Update to 2024U data and warning box about the missing VTQs

@@ -1,6 +1,12 @@
homepage_panel <- function() {
tabPanel(
"Homepage",
modalDialog(

Check warning

Code scanning / lintr

no visible global function definition for 'modalDialog' Warning

no visible global function definition for 'modalDialog'
@@ -1,6 +1,12 @@
homepage_panel <- function() {
tabPanel(
"Homepage",
modalDialog(
title = "Missing data",
"The 16 to 18 transition matrices does not include vocational and technical qualifications for 2024 provisional data due to a data collection issue. This will be resolved in the revised publication.",

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 206 characters. Note

Lines should not be more than 80 characters. This line is 206 characters.
)
),
column(
width = 6,
selectizeInput(
inputId = "grade_structure_select",
label = "5. Select a grade structure",
choices = list(GradeStructures = sort(qual_lookup$gradeStructure))
choices = list(GradeStructures = sort(unique(qual_lookup$gradeStructure)))

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 92 characters. Note

Lines should not be more than 80 characters. This line is 92 characters.
@@ -23,8 +23,8 @@
# ---- Things to change between runs ----
# -----------------------------------------------------------------------------------------------------------------------------

ancillary_save_path <- "//lonnetapp01/DSGA2/!!Secure Data/SFR/2023/KS5/4 Dev/07_development/06_ancillary/"
current_year <- "2023A"
ancillary_save_path <- "//lonnetapp01/DSGA2/!!Secure Data/SFR/2024/KS5/01_november_2024/06_ancillary/"

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 102 characters. Note

Lines should not be more than 80 characters. This line is 102 characters.
@@ -35,7 +35,7 @@


# Select data from SQL tables - need to add the current year for unamended run and change from U to A for the amended run

tm_data_raw_2024 <- tbl(con, sql("select * from [KS5_STATISTICS_RESTRICTED].[TM_2024].[TM_data_2024U]")) %>% collect()

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 118 characters. Note

Lines should not be more than 80 characters. This line is 118 characters.
label = NULL,
choices <- qual_lookup %>%
filter(ReportYr == input$ReportYr_select) %>%
pull(Qual_Description) %>%

Check warning

Code scanning / lintr

no visible binding for global variable 'Qual_Description' Warning

no visible binding for global variable 'Qual_Description'
choices <- qual_lookup %>%
filter(ReportYr == input$ReportYr_select) %>%
pull(Qual_Description) %>%
unique(.) %>%

Check warning

Code scanning / lintr

no visible binding for global variable '.' Warning

no visible binding for global variable '.'
choices <- qual_lookup %>%
filter(ReportYr == input$ReportYr_select) %>%
pull(Qual_Description) %>%
unique(.) %>%

Check warning

Code scanning / lintr

no visible binding for global variable '.' Warning

no visible binding for global variable '.'

observe({
updateSelectInput(session,
inputId = "subj_select",
label = NULL,
choices <- qual_lookup %>%
filter(ReportYr == input$ReportYr_select & Qual_Description == input$qual_select) %>%
filter(
ReportYr == input$ReportYr_select,

Check warning

Code scanning / lintr

no visible binding for global variable 'ReportYr' Warning

no visible binding for global variable 'ReportYr'
filter(ReportYr == input$ReportYr_select & Qual_Description == input$qual_select) %>%
filter(
ReportYr == input$ReportYr_select,
Qual_Description == input$qual_select

Check warning

Code scanning / lintr

no visible binding for global variable 'Qual_Description' Warning

no visible binding for global variable 'Qual_Description'
Copy link
Collaborator

@katie-aisling katie-aisling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved and ready for live

@katie-aisling katie-aisling merged commit 4fc51a0 into master Nov 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants