Dfeshiny update disconnect msg cookies navid #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Addressing the first checkbox of issue #69 . The corrected
{dfeshiny}
functioncustom_disconnect_message()
is now reintegrated into the app and my temporary fix function has been removed (``)Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app()
)styler::style_dir()
andlintr::lint_dir()
)What is the current behaviour?
The
cookies_banner_server_jt()
function is a temporary fix while there is a typo indfeshiny::cookies_banner_server()
. However, this has now been fixed.What is the new behaviour?
See the overview. Closing #69 .
Anything else
Still waiting on {dfeshiny} to add in the option to have both a refresh link to the current bookmarked site and also refresh the site back to its default state. This will address the second checkbox of #69 , which will created as a new issue:
dfe-analytical-services/dfeshiny#80