Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting the formatting on the valueBoxes #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmbielby
Copy link
Contributor

I've adjusted the css code (www/dfe_shiny_gov_style.css) to put some proper padding into the valueBoxes. This helps with the layout of the text.

Also fixed the odd word-wrapping in the valueBoxes, which was caused by them being placed in column environments (sorry, might have been me that did that in the first place!).

Have added some padding into the Box environment as well to help with spacing between elements.

Still needs some work doing on the styling of the plot and the table, but best to do that in another branch.

Here's what it looks like now:

valueBox_formatting

@rmbielby rmbielby requested a review from Hanco20 June 10, 2022 16:12
Copy link
Contributor

@Hanco20 Hanco20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting of boxes looks good, as you say I need to do more on the charts and tables. Is there a DfE format for these or just just personal preference?

If these changes are merged into main and then my branch skill_demand is also merged what happens to the changes, will they be overwritten ?

@Hanco20 Hanco20 closed this Jun 13, 2022
@Hanco20 Hanco20 reopened this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants