Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): Add support for Schnorr auxiliary inputs #3758

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 15, 2024

The PR proposes extending the sign_with_schnorr function to support "key-tweaking" as specified in Taproot (BIP341). An optional auxiliary argument is added to the function inputs, allowing the caller to specify the root of the Merkle tree that encodes alternative spending paths, which is then used by the replicas to tweak the signing key. This enhancement enables canisters to create Bitcoin Taproot addresses that fully comply with the BIP341 specifications.

Background

The Deuterium Milestone introduced support for threshold Schnorr signatures, including Schnorr-BIP340 signatures used in Bitcoin. This allowed canisters to generate Pay-to-Taproot (P2TR) addresses and execute Taproot transactions. P2TR addresses, as defined in BIP341, support two possible spending paths:

  • Key path: Spending by signing a transaction with a Schnorr key.
  • Script path:Spending by revealing an alternative script stored in the leaf of a Merkle tree.

A P2TR address consists of a public key that is derived through an additive key derivation scheme. This process involves hashing the internal public key and the Merkle tree root (representing alternative spending scripts) to derive an "additive tweak." The tweak is then added to both the secret and public keys. To spend using the key path, a transaction must include a signature generated with the tweaked secret key, which corresponds to the tweaked public key embedded in the address.

Motivation

Currently, on the Internet Computer, two types of restricted P2TR addresses can be created:

  • P2TR with an untweaked public key: This type of address does not include a Merkle tree of alternative scripts, meaning it can only be spent via the key path. The creation of such addresses is supported since, for key-path spends, the transaction only requires a valid signature, and the Merkle root is intentionally omitted to conceal whether alternative spending scripts exist.
  • P2TR address with a public key in a Merkle tree leaf: This type of address can only be spent via the script path because canisters currently cannot request the Internet Computer (IC) to sign transactions with a tweaked public key.

This limitation restricts canisters from creating P2TR addresses that support spending using both the key path and script paths. As a result, canisters must decide at the time of address creation how they intend to spend the funds in the future. While this does not seem to constitute an issue to integrate with most Bitcoin meta-protocols, it does reduce the overall flexibility for dapps that require dynamic spending options. Additionally, most libraries do not natively support creating Taproot addresses that can be spent using untweaked keys via the key path. This forces developers to have a deeper understanding of Taproot to integrate the Schnorr signing API in their dapps.

By adding support for key-tweaking in the Schnorr signing API, canisters will be able to create standard Taproot addresses that support both script path and key path spending with a tweaked internal key. This enhancement would make the IC more flexible and aligned with standard Taproot functionality, reducing complexity for developers and dapps.

@mraszyk mraszyk requested a review from a team as a code owner November 15, 2024 11:17
@mraszyk mraszyk added the interface-spec Changes to the IC Interface Specification label Nov 18, 2024
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge coordinated with release in replica

randombit added a commit to dfinity/ic that referenced this pull request Dec 3, 2024
…puts

PR 2523 implemented a management canister interface which does not match
the finalized interface change (dfinity/portal#3758)
github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Dec 4, 2024
…puts (#2952)

PR 2523 implemented a management canister interface which does not match
the finalized interface change
(dfinity/portal#3758)

---------

Co-authored-by: Dimitris Sarlis <[email protected]>
github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Dec 4, 2024
…puts (#2952)

PR 2523 implemented a management canister interface which does not match
the finalized interface change
(dfinity/portal#3758)

---------

Co-authored-by: Dimitris Sarlis <[email protected]>
@randombit
Copy link

Replica changes are now live, should be good to merge

@randombit
Copy link

@mraszyk Ping - just wanted to check if there was any additional steps required before this can be merged

@mraszyk
Copy link
Contributor Author

mraszyk commented Jan 9, 2025

@mraszyk Ping - just wanted to check if there was any additional steps required before this can be merged

Thanks for the ping! If the changes from this PR are now live in production, then let's please merge it!

@mraszyk mraszyk merged commit aed4ac7 into master Jan 10, 2025
8 checks passed
@mraszyk mraszyk deleted the jack/crp-2588 branch January 10, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface-spec Changes to the IC Interface Specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants