-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update showcase.json for Verity #2 #3861
Open
rsoury
wants to merge
6
commits into
dfinity:master
Choose a base branch
from
usherlabs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @rsoury, thank you for this! We are working on a revamp of the page and we will review this tomorrow and make any necessary changes |
Hello @rsoury Verity is not featured on the page so the screenshots will not show. Could you consider removing the file commits and the screenshot value? |
* 'master' of github.com:usherlabs/portal: fix: WSL install instructions (dfinity#3870) fix: http_request_update (dfinity#3868) fix: Link HTTPS outcalls to the https outcalls overview page (dfinity#3872) Update showcase.json (dfinity#3654) Remove overview headings (dfinity#3866) Add icptokens.net to showcase (dfinity#3751) add library to learn menu (dfinity#3867) add library page (dfinity#3864) Update ICRC ledger setup docs to point to the new GitHub releases (dfinity#3862) Update showcase.json fix: Cleanup docs (dfinity#3856) Dev weekly update December 4 2024 (dfinity#3855) lint: add link validation plugin (dfinity#3847) update discord link (dfinity#3857) update discord link (dfinity#3858) optimize images for showcase (dfinity#3853)
@jennifertrin - Done. |
jennifertrin
approved these changes
Dec 26, 2024
Great, thank you. This will go in once this fix goes in: #3919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdx
file format to support the previous two components./sidebars.js
, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERS
file isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.