-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for iframe authentication #118
base: master
Are you sure you want to change the base?
Conversation
Support for iframe authentication
…ndently of its parent project
Hey @dgrubelic, At doxo.com we need oauth2 token authentication in a hidden iframe, thus I added iframe support to this library. Although it's not thoroughly tested (I only verified if it's working with our internal custom provider and none of the public ones like google, facebook, etc.), you may want to consider merging this to the master branch. I think this is a useful addition. One possible caveat—for those using custom providers—is that I renamed the |
… no iframeTarget property (to avoid creating many hidden divs in document)
…sions of Safari where location.port is 0 when port is missing from URL (i.e. it's the default 80)
…to the callback URL
Support older Safari + introduce auth timeout
Fix iframe authentication in Edge
…ed a port even though the original URL didn't contain any. Since this port isn't present in the auth iframe's location, the authentication always timed out. This commit fixes this issue by omitting the parser technique.
… and older Safari)
Fix IE11 string comparison issue (ASH-54)
Thanks for this huge PR, i'll review it and write down my comments. |
Any chance this is getting merged at some point? |
We stopped using |
Beside popup windows make authentication possible in iframes.