Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iframe authentication #118

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

uifox
Copy link

@uifox uifox commented Apr 3, 2018

Beside popup windows make authentication possible in iframes.

@bsarvari
Copy link

bsarvari commented Apr 3, 2018

Hey @dgrubelic,

At doxo.com we need oauth2 token authentication in a hidden iframe, thus I added iframe support to this library. Although it's not thoroughly tested (I only verified if it's working with our internal custom provider and none of the public ones like google, facebook, etc.), you may want to consider merging this to the master branch. I think this is a useful addition.

One possible caveat—for those using custom providers—is that I renamed the popupOptions variable to authContextOptions which breaks backward compatibility.

uifox added 15 commits April 3, 2018 17:59
… no iframeTarget property (to avoid creating many hidden divs in document)
…sions of Safari where location.port is 0 when port is missing from URL (i.e. it's the default 80)
Support older Safari + introduce auth timeout
Fix iframe authentication in Edge
…ed a port even though the original URL didn't contain any. Since this port isn't present in the auth iframe's location, the authentication always timed out. This commit fixes this issue by omitting the parser technique.
Fix IE11 string comparison issue (ASH-54)
@dgrubelic
Copy link
Owner

Thanks for this huge PR, i'll review it and write down my comments.

@NitradoJustus
Copy link

Any chance this is getting merged at some point?

@uifox
Copy link
Author

uifox commented Aug 1, 2019

@NitradoJustus

Any chance this is getting merged at some point?

We stopped using vue-authenticate at doxo. Instead we now use the app-auth library because it better fits our use cases, hence I do not manage this PR anymore. If you need these changes, please feel free to fork my fork, resolve the conflicting files and coordinate with @dgrubelic to get them merged to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants