Use Data.Map.Strict instead of Data.Map #2611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the Hydra build failed. |
@winitzki This shouldn't be related to the code changes, right? |
Right, I believe it has nothing to do with the code changes. All tests passed in this PR. A similar situation is happening right now in another PR: #2513 Most likely it's a stale failed build that Hydra has cached for some reason. Someone needs to restart the server somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to read a 93Mb Dhall file with
inputExprWithSettings(using a small list of subtitutions), Dhall currently crashes due to a spaceleak (presumably). Profiling showed thatDhall.Mapis to blame for the allocations (withtoListbeing the main retainer) and the only way to get this under control was to switch toData.Map.Strict.Is there a specific reason why the lazy
Data.Mapis used in this module? It seems to me that laziness provides no benefit and moving to the strict version is the way to go.Profiling eventlogs (for a smaller file) can be found here: profiling.zip